ajantha-bhat commented on code in PR #9432:
URL: https://github.com/apache/iceberg/pull/9432#discussion_r1448763957
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -251,9 +251,15 @@ public void renameTable(TableIdentifier from,
TableIdentifier originalTo) {
} catch (NoSuchObjectException e) {
throw new NoSuchTableException("Table does not exist: %s", from);
- } catch (AlreadyExistsException e) {
- throw new org.apache.iceberg.exceptions.AlreadyExistsException(
- "Table already exists: %s", to);
+ } catch (RuntimeException e) {
Review Comment:
Originally we were unwrapping to `MetaException` but here were still
catching `RuntimeException`. Hence I gave that comment.
Now we are unwrapping to `TException` and catching the `TException`. So, now
LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
