pvary commented on code in PR #9432:
URL: https://github.com/apache/iceberg/pull/9432#discussion_r1445810556
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/MetastoreUtil.java:
##########
@@ -72,6 +73,23 @@ public static void alterTable(
env.putAll(extraEnv);
env.put(StatsSetupConst.DO_NOT_UPDATE_STATS, StatsSetupConst.TRUE);
- ALTER_TABLE.invoke(client, databaseName, tblName, table, new
EnvironmentContext(env));
+ try {
+ ALTER_TABLE.invoke(client, databaseName, tblName, table, new
EnvironmentContext(env));
+ } catch (RuntimeException e) {
Review Comment:
`alterTable` should return the `MetaException` and where we call it, we
should handle the `InvalidOperationException` with the message of `new table
%s.%s already exists` and translate it to an `AlreadyExistsException`.
We should only consider moving the exception if we find that all of the
places where we call `alterTable` we would like to throw the same
`AlreadyExistsException`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
