nastra commented on code in PR #9381:
URL: https://github.com/apache/iceberg/pull/9381#discussion_r1438122352
##########
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkMetaDataTable.java:
##########
@@ -318,51 +318,50 @@ public void testUnPartitionedTable() throws IOException {
filesTableSchema = filesTableSchema.select(columns);
List<Row> actualDataFiles = sql("SELECT %s FROM %s$data_files", names,
TABLE_NAME);
- Assert.assertEquals("Metadata table should return 2 data file", 2,
actualDataFiles.size());
-
+ assertThat(actualDataFiles).as("Metadata table should return 2 data
file").hasSize(2);
List<GenericData.Record> expectedDataFiles =
expectedEntries(table, FileContent.DATA, entriesTableSchema,
expectedDataManifests, null);
- Assert.assertEquals("Should be 2 data file manifest entry", 2,
expectedDataFiles.size());
+ assertThat(expectedDataFiles).as("Should be 2 data file manifest
entry").hasSize(2);
TestHelpers.assertEquals(filesTableSchema, expectedDataFiles.get(0),
actualDataFiles.get(0));
// check all files table
List<Row> actualFiles = sql("SELECT %s FROM %s$files ORDER BY content",
names, TABLE_NAME);
- Assert.assertEquals("Metadata table should return 3 files", 3,
actualFiles.size());
-
+ assertThat(actualFiles).as("Metadata table should return 3
files").hasSize(3);
List<GenericData.Record> expectedFiles =
Stream.concat(expectedDataFiles.stream(), expectedDeleteFiles.stream())
.collect(Collectors.toList());
- Assert.assertEquals("Should have 3 files manifest entries", 3,
expectedFiles.size());
+ assertThat(expectedFiles).as("Should have 3 files manifest
entriess").hasSize(3);
TestHelpers.assertEquals(filesTableSchema, expectedFiles.get(0),
actualFiles.get(0));
TestHelpers.assertEquals(filesTableSchema, expectedFiles.get(1),
actualFiles.get(1));
}
- @Test
+ @TestTemplate
public void testPartitionedTable() throws Exception {
- Assume.assumeFalse(!isPartition);
+ assumeThat(!isPartition).isFalse();
Review Comment:
```suggestion
assumeThat(isPartition).isTrue();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
