nastra commented on code in PR #9381:
URL: https://github.com/apache/iceberg/pull/9381#discussion_r1438121270
##########
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkMetaDataTable.java:
##########
@@ -164,21 +163,22 @@ public void testHistory() {
Iterator<Snapshot> snapshots = table.snapshots().iterator();
for (Row row : result) {
Snapshot next = snapshots.next();
- Assert.assertEquals(
- "Should have expected made_current_at",
- ((Instant) row.getField(0)).toEpochMilli(),
- next.timestampMillis());
- Assert.assertEquals("Should have expected snapshot id",
next.snapshotId(), row.getField(1));
- Assert.assertEquals("Should have expected parent id", next.parentId(),
row.getField(2));
-
- Assert.assertEquals(
- "Should have expected is current ancestor",
- SnapshotUtil.isAncestorOf(table,
table.currentSnapshot().snapshotId(), next.snapshotId()),
- row.getField(3));
+ assertThat(((Instant) row.getField(0)).toEpochMilli())
Review Comment:
I'm confused about what exactly is the actual vs expected. `testSnapshots()`
has the same issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
