nastra commented on code in PR #9381:
URL: https://github.com/apache/iceberg/pull/9381#discussion_r1438121453
##########
flink/v1.18/flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkMetaDataTable.java:
##########
@@ -189,32 +189,32 @@ public void testManifests() {
for (int i = 0; i < result.size(); i++) {
Row row = result.get(i);
ManifestFile manifestFile = expectedDataManifests.get(i);
- Assert.assertEquals(
- "Should have expected content", manifestFile.content().id(),
row.getField(0));
- Assert.assertEquals("Should have expected path", manifestFile.path(),
row.getField(1));
- Assert.assertEquals("Should have expected length",
manifestFile.length(), row.getField(2));
- Assert.assertEquals(
- "Should have expected partition_spec_id",
- manifestFile.partitionSpecId(),
- row.getField(3));
- Assert.assertEquals(
- "Should have expected added_snapshot_id", manifestFile.snapshotId(),
row.getField(4));
- Assert.assertEquals(
- "Should have expected added_data_files_count",
- manifestFile.addedFilesCount(),
- row.getField(5));
- Assert.assertEquals(
- "Should have expected existing_data_files_count",
- manifestFile.existingFilesCount(),
- row.getField(6));
- Assert.assertEquals(
- "Should have expected deleted_data_files_count",
- manifestFile.deletedFilesCount(),
- row.getField(7));
+ assertThat(manifestFile.content().id())
Review Comment:
shouldn't this be the `expected` part?
`assertThat(actual)...isEqualTo(expected)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
