nastra commented on code in PR #9342:
URL: https://github.com/apache/iceberg/pull/9342#discussion_r1432971413
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestReadProjection.java:
##########
@@ -64,11 +66,14 @@ public void testFullProjection() throws Exception {
Record projected = writeAndRead("full_projection", schema, schema, record);
- Assert.assertEquals(
- "Should contain the correct id value", 34L, (long)
projected.getField("id"));
+ assertThat((long) projected.getField("id"))
+ .as("Should contain the correct id value")
+ .isEqualTo(34L);
int cmp =
Comparators.charSequences().compare("test", (CharSequence)
projected.getField("data"));
+
+ // TODO: update this Assert with AssertJ
Review Comment:
sorry for the mis-communication, that's my bad. I didn't mean to mention
`org.junit.Assert`. In order for the test to be a JUnit4 test it just needs
`org.junit.Rule` / `org.junit.Test` / `org.junit.rules.TemporaryFolder`. The
assertions being used can be AssertJ (which you already converted)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
