lschetanrao commented on code in PR #9241:
URL: https://github.com/apache/iceberg/pull/9241#discussion_r1420860637
##########
mr/src/test/java/org/apache/iceberg/mr/hive/HiveIcebergTestUtils.java:
##########
@@ -288,9 +287,10 @@ public static void validateFiles(Table table,
Configuration conf, JobID jobId, i
.filter(path -> !path.getFileName().toString().startsWith("."))
.collect(Collectors.toList());
- Assert.assertEquals(dataFileNum, dataFiles.size());
- Assert.assertFalse(
- new
File(HiveIcebergOutputCommitter.generateJobLocation(table.location(), conf,
jobId))
- .exists());
+ Assertions.assertThat(dataFiles.size()).isEqualTo(dataFileNum);
Review Comment:
done
##########
mr/src/test/java/org/apache/iceberg/mr/hive/HiveIcebergTestUtils.java:
##########
@@ -288,9 +287,10 @@ public static void validateFiles(Table table,
Configuration conf, JobID jobId, i
.filter(path -> !path.getFileName().toString().startsWith("."))
.collect(Collectors.toList());
- Assert.assertEquals(dataFileNum, dataFiles.size());
- Assert.assertFalse(
- new
File(HiveIcebergOutputCommitter.generateJobLocation(table.location(), conf,
jobId))
- .exists());
+ Assertions.assertThat(dataFiles.size()).isEqualTo(dataFileNum);
+ Assertions.assertThat(
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
