lschetanrao commented on code in PR #9241:
URL: https://github.com/apache/iceberg/pull/9241#discussion_r1420852196
##########
mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergOutputCommitter.java:
##########
@@ -201,22 +203,22 @@ public void writerIsClosedAfterTaskCommitFailure() throws
IOException {
.when(failingCommitter)
.commitTask(argumentCaptor.capture());
- Table table = table(temp.getRoot().getPath(), false);
+ Table table = table(temp.toFile().getPath(), false);
JobConf conf = jobConf(table, 1);
Assertions.assertThatThrownBy(
() -> writeRecords(table.name(), 1, 0, true, false, conf,
failingCommitter))
.isInstanceOf(RuntimeException.class)
.hasMessage(exceptionMessage);
- Assert.assertEquals(1, argumentCaptor.getAllValues().size());
+ Assertions.assertThat(argumentCaptor.getAllValues().size()).isEqualTo(1);
Review Comment:
Fixed this in
https://github.com/apache/iceberg/pull/9241/commits/10a0099520665385bdb837372f27f17f1a41c50f
##########
mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergSerDe.java:
##########
@@ -34,22 +35,21 @@
import org.apache.iceberg.mr.hive.serde.objectinspector.IcebergObjectInspector;
import org.apache.iceberg.mr.mapred.Container;
import org.apache.iceberg.types.Types;
-import org.junit.Assert;
-import org.junit.Rule;
-import org.junit.Test;
-import org.junit.rules.TemporaryFolder;
+import org.assertj.core.api.Assertions;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.io.TempDir;
public class TestHiveIcebergSerDe {
private static final Schema schema =
new Schema(required(1, "string_field", Types.StringType.get()));
- @Rule public TemporaryFolder tmp = new TemporaryFolder();
+ @TempDir public Path tmp;
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
