lschetanrao commented on code in PR #9241:
URL: https://github.com/apache/iceberg/pull/9241#discussion_r1420851466
##########
mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergFilterFactory.java:
##########
@@ -82,10 +80,12 @@ public void testNotEqualsOperand() {
UnboundPredicate childExpressionActual = (UnboundPredicate) actual.child();
UnboundPredicate childExpressionExpected = Expressions.equal("salary",
3000L);
- assertEquals(actual.op(), expected.op());
- assertEquals(actual.child().op(), expected.child().op());
- assertEquals(childExpressionActual.ref().name(),
childExpressionExpected.ref().name());
- assertEquals(childExpressionActual.literal(),
childExpressionExpected.literal());
+ Assertions.assertThat(expected.op()).isEqualTo(actual.op());
Review Comment:
Yes Got it.
##########
mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergOutputCommitter.java:
##########
@@ -80,7 +79,7 @@ public class TestHiveIcebergOutputCommitter {
private static final PartitionSpec PARTITIONED_SPEC =
PartitionSpec.builderFor(CUSTOMER_SCHEMA).bucket("customer_id",
3).build();
- @Rule public TemporaryFolder temp = new TemporaryFolder();
+ @TempDir public Path temp;
Review Comment:
Got it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
