pvary commented on code in PR #9173: URL: https://github.com/apache/iceberg/pull/9173#discussion_r1415488728
########## flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java: ########## @@ -197,13 +187,13 @@ private SplitEnumerator<IcebergSourceSplit, IcebergEnumeratorState> createEnumer LOG.info( "Iceberg source restored {} splits from state for table {}", enumState.pendingSplits().size(), - lazyTable().name()); + tableName); assigner = assignerFactory.createAssigner(enumState.pendingSplits()); } - + TableLoader tableLoaderCopy = tableLoader.clone(); Review Comment: nit: Could we just do a: ``` new ContinuousSplitPlannerImpl(tableLoader.clone(), scanContext, planningThreadName()); ``` ########## flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java: ########## @@ -197,13 +187,13 @@ private SplitEnumerator<IcebergSourceSplit, IcebergEnumeratorState> createEnumer LOG.info( "Iceberg source restored {} splits from state for table {}", enumState.pendingSplits().size(), - lazyTable().name()); + tableName); assigner = assignerFactory.createAssigner(enumState.pendingSplits()); } - + TableLoader tableLoaderCopy = tableLoader.clone(); Review Comment: Not needed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org