stevenzwu commented on code in PR #9173:
URL: https://github.com/apache/iceberg/pull/9173#discussion_r1420908320
##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java:
##########
@@ -105,12 +107,12 @@ public class IcebergSource<T> implements Source<T,
IcebergSourceSplit, IcebergEn
this.readerFunction = readerFunction;
this.assignerFactory = assignerFactory;
this.splitComparator = splitComparator;
- this.table = table;
this.emitter = emitter;
+ this.tableName = table.name();
Review Comment:
Now I understand Mason's comment. totally agree that it is more readable to
move the `checkRequired()` inside the constructor. now it is detached.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
