mas-chen commented on code in PR #9173:
URL: https://github.com/apache/iceberg/pull/9173#discussion_r1414397623
##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/source/IcebergSource.java:
##########
@@ -197,17 +203,21 @@ private SplitEnumerator<IcebergSourceSplit,
IcebergEnumeratorState> createEnumer
LOG.info(
"Iceberg source restored {} splits from state for table {}",
enumState.pendingSplits().size(),
- lazyTable().name());
+ tableName());
assigner = assignerFactory.createAssigner(enumState.pendingSplits());
}
+ // Create a copy of the table loader to avoid lifecycle management
conflicts with the user
+ // provided table loader. This copy is only required for split planning,
which uses the
+ // underlying io, and should be closed after split planning is complete
Review Comment:
I agree with the pattern.
wrt to the lazytable thing, this is because the `Table` needed to be a
transient value. But it seems we do not make a reference to it outside of the
lazytable, so I will remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
