huaxingao commented on code in PR #9010:
URL: https://github.com/apache/iceberg/pull/9010#discussion_r1395125605
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetBloomRowGroupFilter.java:
##########
@@ -114,10 +119,17 @@ private boolean eval(
Set<Integer> filterRefs =
Binder.boundReferences(schema.asStruct(), ImmutableList.of(expr),
caseSensitive);
- // If the filter's column set doesn't overlap with any bloom filter
columns, exit early with
- // ROWS_MIGHT_MATCH
- if (!filterRefs.isEmpty() && Sets.intersection(fieldsWithBloomFilter,
filterRefs).isEmpty()) {
- return ROWS_MIGHT_MATCH;
+ if (!filterRefs.isEmpty()) {
+ Sets.SetView overlappedBloomFilters =
Sets.intersection(fieldsWithBloomFilter, filterRefs);
Review Comment:
Changed. Thanks!
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetBloomRowGroupFilter.java:
##########
@@ -114,10 +119,17 @@ private boolean eval(
Set<Integer> filterRefs =
Binder.boundReferences(schema.asStruct(), ImmutableList.of(expr),
caseSensitive);
- // If the filter's column set doesn't overlap with any bloom filter
columns, exit early with
- // ROWS_MIGHT_MATCH
- if (!filterRefs.isEmpty() && Sets.intersection(fieldsWithBloomFilter,
filterRefs).isEmpty()) {
- return ROWS_MIGHT_MATCH;
+ if (!filterRefs.isEmpty()) {
+ Sets.SetView overlappedBloomFilters =
Sets.intersection(fieldsWithBloomFilter, filterRefs);
+ if (overlappedBloomFilters.isEmpty()) {
+ // If the filter's column set doesn't overlap with any bloom filter
columns, exit early
Review Comment:
Removed. Thanks!
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetBloomRowGroupFilter.java:
##########
@@ -114,10 +119,17 @@ private boolean eval(
Set<Integer> filterRefs =
Binder.boundReferences(schema.asStruct(), ImmutableList.of(expr),
caseSensitive);
- // If the filter's column set doesn't overlap with any bloom filter
columns, exit early with
- // ROWS_MIGHT_MATCH
- if (!filterRefs.isEmpty() && Sets.intersection(fieldsWithBloomFilter,
filterRefs).isEmpty()) {
- return ROWS_MIGHT_MATCH;
+ if (!filterRefs.isEmpty()) {
+ Sets.SetView overlappedBloomFilters =
Sets.intersection(fieldsWithBloomFilter, filterRefs);
+ if (overlappedBloomFilters.isEmpty()) {
+ // If the filter's column set doesn't overlap with any bloom filter
columns, exit early
+ // with ROWS_MIGHT_MATCH
+ return ROWS_MIGHT_MATCH;
+ } else {
+ LOG.debug(
Review Comment:
Changed. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
