aokolnychyi commented on code in PR #9010:
URL: https://github.com/apache/iceberg/pull/9010#discussion_r1388717988


##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetBloomRowGroupFilter.java:
##########
@@ -120,6 +124,9 @@ private boolean eval(
         return ROWS_MIGHT_MATCH;
       }
 
+      LOG.info(
+          "Bloom Filters are used. The following fields have bloom filters : 
{}",

Review Comment:
   The case sensitivity seems off. I think we should use `Bloom filter` vs 
`bloom filter` or `Bloom Filter`. 
   Also, would it be more informative to report the intersection of the filter 
and all bloom filter columns? We probably don't care about having Bloom filters 
for columns that are not referenced by the filter?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to