aokolnychyi commented on code in PR #9010:
URL: https://github.com/apache/iceberg/pull/9010#discussion_r1395044921
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetBloomRowGroupFilter.java:
##########
@@ -114,10 +119,17 @@ private boolean eval(
Set<Integer> filterRefs =
Binder.boundReferences(schema.asStruct(), ImmutableList.of(expr),
caseSensitive);
- // If the filter's column set doesn't overlap with any bloom filter
columns, exit early with
- // ROWS_MIGHT_MATCH
- if (!filterRefs.isEmpty() && Sets.intersection(fieldsWithBloomFilter,
filterRefs).isEmpty()) {
- return ROWS_MIGHT_MATCH;
+ if (!filterRefs.isEmpty()) {
+ Sets.SetView overlappedBloomFilters =
Sets.intersection(fieldsWithBloomFilter, filterRefs);
+ if (overlappedBloomFilters.isEmpty()) {
+ // If the filter's column set doesn't overlap with any bloom filter
columns, exit early
Review Comment:
How useful is this comment after we nested this if condition? It seems
pretty obvious to me given the naming of the variables. I'd probably remove. Up
to you, @huaxingao.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
