nastra commented on code in PR #8918: URL: https://github.com/apache/iceberg/pull/8918#discussion_r1375773663
########## hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalog.java: ########## @@ -176,8 +224,8 @@ public void testToStringWithoutSetConf() { assertThatNoException() .isThrownBy( () -> { - HiveCatalog catalog = new HiveCatalog(); - catalog.toString(); + HiveCatalog hiveCatalog = new HiveCatalog(); + hiveCatalog.toString(); Review Comment: all of the diffs around catalog/hiveCatalog can be avoided -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org