nastra commented on code in PR #8918:
URL: https://github.com/apache/iceberg/pull/8918#discussion_r1375074725
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalog.java:
##########
@@ -96,6 +105,43 @@ public class TestHiveCatalog extends HiveMetastoreTest {
@TempDir private Path temp;
+ private HiveMetastoreSetup hiveMetastoreSetup;
+
+ private static final String HIVE_DB_NAME = "hivedb";
Review Comment:
why not just call this `DB_NAME` so that you don't have to adjust all of the
places?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
