nastra commented on code in PR #8918:
URL: https://github.com/apache/iceberg/pull/8918#discussion_r1375077284
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalog.java:
##########
@@ -850,51 +857,46 @@ private void removeNamespaceOwnershipAndVerify(
createNamespaceAndVerifyOwnership(
name, propToCreate, expectedOwnerPostCreate,
expectedOwnerTypePostCreate);
- catalog.removeProperties(Namespace.of(name), propToRemove);
+ catalog().removeProperties(Namespace.of(name), propToRemove);
- Database database = metastoreClient.getDatabase(name);
+ Database database = hiveMetastoreSetup.metastoreClient.getDatabase(name);
assertThat(database.getOwnerName()).isEqualTo(expectedOwnerPostRemove);
assertThat(database.getOwnerType()).isEqualTo(expectedOwnerTypePostRemove);
}
@Test
- public void testDropNamespace() throws TException {
+ public void testDropEmptyNamespace() throws TException {
Review Comment:
can we please leave refactorings out of this PR? THis file should only have
a minimal set of changes (by adding the setup/teardown stuff(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
