rdblue commented on code in PR #8660:
URL: https://github.com/apache/iceberg/pull/8660#discussion_r1338901318
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java:
##########
@@ -649,6 +668,39 @@ private String deleteOrcCompressionStrategy() {
.option(SparkWriteOptions.COMPRESSION_STRATEGY)
.sessionConf(SparkSQLProperties.COMPRESSION_STRATEGY)
.tableProperty(DELETE_ORC_COMPRESSION_STRATEGY)
- .parseOptional();
+ .defaultValue(orcCompressionStrategy())
+ .parse();
+ }
+
+ private long dataAdvisoryPartitionSize() {
+ long defaultValue =
+ advisoryPartitionSize(DATA_FILE_SIZE, dataFileFormat(),
dataCompressionCodec());
+ return advisoryPartitionSize(defaultValue);
+ }
+
+ private long deleteAdvisoryPartitionSize() {
+ long defaultValue =
+ advisoryPartitionSize(DELETE_FILE_SIZE, deleteFileFormat(),
deleteCompressionCodec());
+ return advisoryPartitionSize(defaultValue);
+ }
+
+ private long advisoryPartitionSize(long defaultValue) {
+ return confParser
Review Comment:
I think this is okay, although since the default differs between data and
deletes, it seems strange not to allow setting this specifically for deletes.
The write option makes sense, but the table and session properties would likely
differ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
