[GitHub] [iceberg] rdblue commented on a diff in pull request #8660: Spark 3.5: Increase default advisory partition size for writes

[via GitHub]

rdblue commented on code in PR #8660:
URL: https://github.com/apache/iceberg/pull/8660#discussion_r1338896352


##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkConfParser.java:
##########
@@ -106,7 +106,7 @@ public int parse() {
     }
 
     public Integer parseOptional() {
-      return parse(Integer::parseInt, null);
+      return parse(Integer::parseInt, defaultValue);

Review Comment:
   Oh, I see. You can have a `null` default for objects like String. I think 
that's fine for String but when the `defaultValue` is set as a primitive `long` 
or `int` I think we don't need to support `parseOptional` and require `parse`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org