rdblue commented on code in PR #8660:
URL: https://github.com/apache/iceberg/pull/8660#discussion_r1338898487
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java:
##########
@@ -484,42 +525,24 @@ private Map<String, String> deleteWriteProperties() {
switch (deleteFormat) {
case PARQUET:
- setWritePropertyWithFallback(
Review Comment:
This seems fine to me, but was it related to the advisory partition size
changes? It seems like it doesn't overlap.Maybe just because we're predicting
the compression ratio based on the codec?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
