aokolnychyi commented on code in PR #8660:
URL: https://github.com/apache/iceberg/pull/8660#discussion_r1337890184
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeltaWrite.java:
##########
@@ -132,7 +132,9 @@ class SparkPositionDeltaWrite implements DeltaWrite,
RequiresDistributionAndOrde
@Override
public Distribution requiredDistribution() {
- return writeRequirements.distribution();
+ Distribution distribution = writeRequirements.distribution();
Review Comment:
Both `Distribution` and `SortOrder` implementation in Spark provide
reasonable `toString()`.
```
23/09/26 17:00:55 INFO SparkWrite: Requesting 402653184 bytes advisory
partition size for table testhive.default.table
23/09/26 17:00:55 INFO SparkWrite: Requesting
ClusteredDistribution(bucket(8, c3)) as write distribution for table
testhive.default.table
23/09/26 17:00:55 INFO SparkWrite: Requesting [bucket(8, c3) ASC NULLS
FIRST, id ASC NULLS FIRST] as write ordering for table testhive.default.table
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
