[GitHub] [iceberg] aokolnychyi commented on a diff in pull request #8660: Spark 3.5: Increase default advisory partition size for writes

[via GitHub]

aokolnychyi commented on code in PR #8660:
URL: https://github.com/apache/iceberg/pull/8660#discussion_r1337886285


##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkWriteRequirements.java:
##########
@@ -47,4 +51,8 @@ public SortOrder[] ordering() {
   public boolean hasOrdering() {
     return ordering.length != 0;
   }
+
+  public long advisoryPartitionSize() {
+    return distribution instanceof UnspecifiedDistribution ? 0 : 
advisoryPartitionSize;

Review Comment:
   Spark will complain if we request a value > 0 with `UnspecifiedDistribution`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org