aokolnychyi commented on code in PR #8660:
URL: https://github.com/apache/iceberg/pull/8660#discussion_r1337885286
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java:
##########
@@ -484,42 +525,24 @@ private Map<String, String> deleteWriteProperties() {
switch (deleteFormat) {
case PARQUET:
- setWritePropertyWithFallback(
Review Comment:
Instead of using `setWritePropertyWithFallback`, I added defaults to our
delete configs. It made my life easier as I needed to know the delete output
codec.
There are tests in `TestCompressionSettings` and `TestSparkWriteConf` to
verify the new logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
