jbonofre commented on code in PR #8612:
URL: https://github.com/apache/iceberg/pull/8612#discussion_r1333940375
##########
aws/src/main/java/org/apache/iceberg/aws/AwsClientFactories.java:
##########
@@ -90,28 +91,35 @@ private static AwsClientFactory loadClientFactory(String
impl, Map<String, Strin
static class DefaultAwsClientFactory implements AwsClientFactory {
private AwsProperties awsProperties;
+ private AwsClientProperties awsClientProperties;
+ private S3FileIOProperties s3FileIOProperties;
+ private HttpClientProperties httpClientProperties;
DefaultAwsClientFactory() {
awsProperties = new AwsProperties();
+ awsClientProperties = new AwsClientProperties();
+ s3FileIOProperties = new S3FileIOProperties();
+ httpClientProperties = new HttpClientProperties();
}
@Override
public S3Client s3() {
- return S3Client.builder()
- .applyMutation(awsProperties::applyClientRegionConfiguration)
- .applyMutation(awsProperties::applyHttpClientConfigurations)
- .applyMutation(awsProperties::applyS3EndpointConfigurations)
- .applyMutation(awsProperties::applyS3ServiceConfigurations)
- .applyMutation(awsProperties::applyS3CredentialConfigurations)
- .applyMutation(awsProperties::applyS3SignerConfiguration)
- .build();
+ S3ClientBuilder builder = S3Client.builder();
+
builder.applyMutation(awsClientProperties::applyClientRegionConfiguration);
Review Comment:
Sure, no problem, let me use the chaining, I'm updating the PR accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
