jbonofre commented on code in PR #8612:
URL: https://github.com/apache/iceberg/pull/8612#discussion_r1333939837
##########
aws/src/main/java/org/apache/iceberg/aws/AwsClientProperties.java:
##########
@@ -57,7 +57,7 @@ public class AwsClientProperties implements Serializable {
* classes to pass provider-specific properties. Each property consists of a
key name and an
* associated value.
*/
- private static final String CLIENT_CREDENTIAL_PROVIDER_PREFIX =
"client.credentials-provider.";
+ protected static final String CLIENT_CREDENTIAL_PROVIDER_PREFIX =
"client.credentials-provider.";
Review Comment:
Good catch: I forgot to clean the use of this property in `AwsProperties`:
```
this.clientCredentialsProvider =
properties.get(AwsClientProperties.CLIENT_CREDENTIALS_PROVIDER);
this.clientCredentialsProviderProperties =
PropertyUtil.propertiesWithPrefix(
properties,
AwsClientProperties.CLIENT_CREDENTIAL_PROVIDER_PREFIX);
```
Let me update with cleanup there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
