nastra commented on code in PR #8612:
URL: https://github.com/apache/iceberg/pull/8612#discussion_r1333861509
##########
aws/src/main/java/org/apache/iceberg/aws/AssumeRoleAwsClientFactory.java:
##########
@@ -34,40 +35,42 @@
public class AssumeRoleAwsClientFactory implements AwsClientFactory {
private AwsProperties awsProperties;
+ private HttpClientProperties httpClientProperties;
+ private S3FileIOProperties s3FileIOProperties;
Review Comment:
it seems those are never assigned, which needs to happen in `initialize(..)`:
```
---
a/aws/src/main/java/org/apache/iceberg/aws/AssumeRoleAwsClientFactory.java
+++
b/aws/src/main/java/org/apache/iceberg/aws/AssumeRoleAwsClientFactory.java
@@ -78,6 +78,8 @@ public class AssumeRoleAwsClientFactory implements
AwsClientFactory {
@Override
public void initialize(Map<String, String> properties) {
this.awsProperties = new AwsProperties(properties);
+ this.s3FileIOProperties = new S3FileIOProperties(properties);
+ this.httpClientProperties = new HttpClientProperties(properties);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
