bryanck commented on code in PR #8555:
URL: https://github.com/apache/iceberg/pull/8555#discussion_r1326414370


##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java:
##########
@@ -149,6 +156,12 @@ public void initializeState(StateInitializationContext 
context) throws Exception
     // Open the table loader and load the table.
     this.tableLoader.open();
     this.table = tableLoader.loadTable();
+    if (reloadIntervalMs > 0) {
+      this.tableSupplier = new ReloadingTableSupplier(table, tableLoader, 
reloadIntervalMs);

Review Comment:
   `TableLoader` is specifically for loading a table from the source of truth, 
e.g. a catalog or HadoopTables. A `TableSupplier` implementation might get the 
table from someplace else, like the delegation framework or a broadcast (the 
initial TableSupplier implementation uses a TableLoader).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to