bryanck commented on code in PR #8555:
URL: https://github.com/apache/iceberg/pull/8555#discussion_r1326410140
##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java:
##########
@@ -302,9 +320,10 @@ private void commitPendingResult(
private void deleteCommittedManifests(
List<ManifestFile> manifests, String newFlinkJobId, long checkpointId) {
+ FileIO fileIO = table.io();
Review Comment:
Initially the was to ensure the same file IO was used in the loop. I removed
this, now that the table load doesn't happen in the supplier's `get()` method
anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]