pvary commented on code in PR #8555:
URL: https://github.com/apache/iceberg/pull/8555#discussion_r1327041574
##########
flink/v1.17/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergFilesCommitter.java:
##########
@@ -149,6 +156,12 @@ public void initializeState(StateInitializationContext
context) throws Exception
// Open the table loader and load the table.
this.tableLoader.open();
this.table = tableLoader.loadTable();
+ if (reloadIntervalMs > 0) {
+ this.tableSupplier = new ReloadingTableSupplier(table, tableLoader,
reloadIntervalMs);
Review Comment:
The first part of the comment is relevant anyway:
- We should not create the supplier in the committer - we should get it from
the Sink as an initialization parameter. We should keep the supplier creation
in one place.
About the Loader vs. Supplier, I think from the consumer side they have the
same functionality - get the table from the source of truth.... Should we use
the same interface?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
