szehon-ho commented on code in PR #8289:
URL: https://github.com/apache/iceberg/pull/8289#discussion_r1294976506


##########
spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewritePositionDeleteFilesProcedure.java:
##########
@@ -130,6 +141,42 @@ public void testExpireDeleteFilesNoOption() throws 
Exception {
         output);
   }
 
+  @Test
+  public void testExpireDeleteFilesFilter() throws Exception {
+    createTable(true);
+
+    sql("DELETE FROM %s WHERE data='a'", tableName);
+    sql("DELETE FROM %s WHERE data='c'", tableName);
+    sql("DELETE FROM %s WHERE data='e'", tableName);

Review Comment:
   @dramaticlly I improved the test to be more interesting, let me know if it 
looks better.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to