szehon-ho commented on code in PR #8289:
URL: https://github.com/apache/iceberg/pull/8289#discussion_r1294954450
##########
spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewritePositionDeleteFilesProcedure.java:
##########
@@ -41,19 +41,30 @@ public TestRewritePositionDeleteFilesProcedure(
}
private void createTable() throws Exception {
+ createTable(false);
+ }
+
+ private void createTable(boolean partitioned) throws Exception {
+ String partitionStmt = partitioned ? "PARTITIONED BY (id)" : "";
Review Comment:
Hm, I think it would be shorter to keep it boolean? There's a lot of test
that have util methods that take in ```boolean partitioned```
Is it not straightforward because it implicitly chooses the partition column
for the caller? I think to me, its fine as anyway the schema is hidden from
user.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
