szehon-ho commented on code in PR #8289:
URL: https://github.com/apache/iceberg/pull/8289#discussion_r1294956538
##########
spark/v3.4/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewritePositionDeleteFilesProcedure.java:
##########
@@ -130,6 +141,42 @@ public void testExpireDeleteFilesNoOption() throws
Exception {
output);
}
+ @Test
+ public void testExpireDeleteFilesFilter() throws Exception {
+ createTable(true);
+
+ sql("DELETE FROM %s WHERE data='a'", tableName);
+ sql("DELETE FROM %s WHERE data='c'", tableName);
+ sql("DELETE FROM %s WHERE data='e'", tableName);
Review Comment:
Yea its a bit of a lame test, I actually just make one delete file in each
partition (3 partitions, 3 files), and then rewrite all to force 2 out of 3 to
be rewritten because I have a partition filter. The rewrite just puts those 2
back as is, because they cant go across partition boundaries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
