aokolnychyi commented on code in PR #8297:
URL: https://github.com/apache/iceberg/pull/8297#discussion_r1293749400
##########
api/src/main/java/org/apache/iceberg/metrics/Counter.java:
##########
@@ -29,6 +29,8 @@ public interface Counter {
/**
* Increment the counter by the provided amount.
*
+ * <p>Implementations may skip the overflow check for better write
throughput.
Review Comment:
I see that `DefaultCounter` has no other method-level docs so I'd probably
just stick to a note in the public interface for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
