mystic-lama commented on code in PR #8297:
URL: https://github.com/apache/iceberg/pull/8297#discussion_r1293737442
##########
api/src/main/java/org/apache/iceberg/metrics/Counter.java:
##########
@@ -29,6 +29,8 @@ public interface Counter {
/**
* Increment the counter by the provided amount.
*
+ * <p>Implementations may skip the overflow check for better write
throughput.
Review Comment:
Should we add in DefaultCounter that it doesn't check for overflow? Not sure
if it's too much. Just dropping a note
##########
api/src/main/java/org/apache/iceberg/metrics/Counter.java:
##########
@@ -29,6 +29,8 @@ public interface Counter {
/**
* Increment the counter by the provided amount.
*
+ * <p>Implementations may skip the overflow check for better write
throughput.
Review Comment:
Should we add in DefaultCounter that it doesn't check for overflow? Not sure
if it's too much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
