mystic-lama commented on code in PR #8297:
URL: https://github.com/apache/iceberg/pull/8297#discussion_r1292593746
##########
api/src/main/java/org/apache/iceberg/metrics/DefaultCounter.java:
##########
@@ -63,7 +63,6 @@ public void increment() {
@Override
public void increment(long amount) {
- Math.addExact(counter.longValue(), amount);
Review Comment:
ctx.scanMetrics().totalFileSizeInBytes().increment(dataFile.fileSizeInBytes())
is the one that had the potential. With long as datatype, it's like 8192
Petabyte data read, so doesn't seem to be an issue as of now :)
Just curious, since it's a public class and if someone is using it, should
we mention this in javadoc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
