bryanck commented on code in PR #8169:
URL: https://github.com/apache/iceberg/pull/8169#discussion_r1284688487
##########
core/src/test/java/org/apache/iceberg/io/TestResolvingIO.java:
##########
@@ -47,4 +55,23 @@ public void testResolvingFileIOJavaSerialization() throws
IOException, ClassNotF
FileIO roundTripSerializedFileIO =
TestHelpers.roundTripSerialize(testResolvingFileIO);
assertThat(roundTripSerializedFileIO.properties()).isEqualTo(testResolvingFileIO.properties());
}
+
+ @Test
+ public void testEnsureInterfaceImplementation() {
+ ResolvingFileIO testResolvingFileIO = spy(new ResolvingFileIO());
Review Comment:
I looked into using Java SPI, but I don't think it is a good idea as it
could cause problems with shadow jars. Also it isn't much different than this
solution. We can't register with ResolvingFileIO from the delegate class as the
delegate class might not be loaded at all yet.
One option, somewhat similar to https://github.com/apache/iceberg/pull/7976
would be to remove `SupportsPrefixOperations` and then provide a default
implementation for bulk delete for the orphan file case so the delegate doesn't
need the mixin interface. Though I was hoping we could have the prefix
operations also as they won't be accessible at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
