bryanck commented on code in PR #8169:
URL: https://github.com/apache/iceberg/pull/8169#discussion_r1283650373
##########
core/src/main/java/org/apache/iceberg/io/ResolvingFileIO.java:
##########
@@ -129,28 +162,31 @@ public Configuration getConf() {
return hadoopConf.get();
}
- private FileIO io(String location) {
+ private <T extends FileIO & SupportsPrefixOperations &
SupportsBulkOperations> T io(
+ String location) {
String impl = implFromLocation(location);
- FileIO io = ioInstances.get(impl);
+ T io = (T) ioInstances.get(impl);
Review Comment:
I originally had it that way, but it required changing the class declaration
and caused the revapi check to fail, I'm not sure what the tolerance is to make
that change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
