bryanck commented on code in PR #8169:
URL: https://github.com/apache/iceberg/pull/8169#discussion_r1284703870
##########
core/src/test/java/org/apache/iceberg/io/TestResolvingIO.java:
##########
@@ -47,4 +55,23 @@ public void testResolvingFileIOJavaSerialization() throws
IOException, ClassNotF
FileIO roundTripSerializedFileIO =
TestHelpers.roundTripSerialize(testResolvingFileIO);
assertThat(roundTripSerializedFileIO.properties()).isEqualTo(testResolvingFileIO.properties());
}
+
+ @Test
+ public void testEnsureInterfaceImplementation() {
+ ResolvingFileIO testResolvingFileIO = spy(new ResolvingFileIO());
Review Comment:
I added tests for each of the delegate types to ensure they load. Though
that doesn't prevent a new class from being added to the list that doesn't
implement the interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
