junegunn commented on PR #7580: URL: https://github.com/apache/hbase/pull/7580#issuecomment-3709564734
> If user just initialize one RpcClient in their program, then removing the singleton pattern does not break anything, we still only initialize the provider once. We currently use `SaslClientAuthenticationProviders` in `RpcConnection`, so the `configure` will be called for each region server, right? I mean, if the user has a custom implementation of `configure` that takes 10 seconds, they will experience the delay multiple times. Or even worse, their `configure` might not be idempotent and break if called multiple times. That's what I was worried about, but we can move the instantiation to the `RpcClient` layer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
