Apache9 commented on PR #7580: URL: https://github.com/apache/hbase/pull/7580#issuecomment-3710626222
> > And on the tests, you need to call providers.reset otherwise the test can pass without any fix... > > Yeah, I did that in [the first commit](https://github.com/apache/hbase/pull/7580/changes/c9a015b94f8ebb47b51c58526623fb5646cc4ce0), but I later removed it in the second commit as it became pointless. > > > We could retain the getInstance method and mark it as deprecated to notice users that you should not use it any more. > > I also considered that, but I decided it was unnecessary because `SaslClientAuthenticationProviders` is mostly an internal class and I couldn't imagine users directly calling the methods of that class. > > Anyway, I'll fine with you taking over from here. I think we just need to mention that `AuthenticationProvider` is going to created for "each connection" (which should be acceptable in 99.9% of cases) in the release note. It is a Connection instance per HBase cluster, not a RpcConnection per region server, which should be OK I assume :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
