junegunn commented on PR #7580: URL: https://github.com/apache/hbase/pull/7580#issuecomment-3708651799
In the last commit, I extended the interface to accept a `Configuration` object and use it when selecting an `AuthenticationProvider`. This new method comes with a default implementation which uses the cached object as before, so that the existing implementations doesn't need to be updated. Alternatively, we could just remove the "singleton-ness" of `SaslClientAuthenticationProviders`. However, it is possible that existing custom `AuthenticationProviderSelectors` might rely on this single-instantiation behavior and perform costly operations in their `configure` method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
