wchevreuil commented on code in PR #6897:
URL: https://github.com/apache/hbase/pull/6897#discussion_r2053741919
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##########
@@ -911,6 +900,22 @@ boolean evictBucketEntryIfNoRpcReferenced(BlockCacheKey
blockCacheKey, BucketEnt
return false;
}
+ @Override
+ public void onConfigurationChange(Configuration config) {
+ this.acceptableFactor = conf.getFloat(ACCEPT_FACTOR_CONFIG_NAME,
DEFAULT_ACCEPT_FACTOR);
Review Comment:
Yes. We can't make any of the bucket allocation related properties, such as
bucket sizes and cache size dynamic as those would require a reset of the
cache.
The properties being updated here are not related to the cache size, nor how
the cache spaces are allocated, so it won't cause a cache reset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
