wchevreuil commented on code in PR #6897:
URL: https://github.com/apache/hbase/pull/6897#discussion_r2053733061
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/bucket/BucketCache.java:
##########
@@ -450,6 +436,9 @@ private void sanityCheckConfigs() {
Preconditions.checkArgument((singleFactor + multiFactor + memoryFactor) ==
1,
SINGLE_FACTOR_CONFIG_NAME + ", " + MULTI_FACTOR_CONFIG_NAME + ", and "
+ MEMORY_FACTOR_CONFIG_NAME + " segments must add up to 1.0");
+ if (this.persistenceChunkSize <= 0) {
Review Comment:
This check was previously being done outside of sanityCheckConfigs (see line
358 on the original version), since it is a sanity check, though it makes sense
to move it here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
