wchevreuil commented on code in PR #6897:
URL: https://github.com/apache/hbase/pull/6897#discussion_r2037160300
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/BlockCache.java:
##########
@@ -279,4 +280,14 @@ default boolean isCacheEnabled() {
default boolean waitForCacheInitialization(long timeout) {
return true;
}
+
+ /**
+ * Allows for BlockCache implementations to provide a mean to refresh their
configurations. Since
+ * HBASE-28517, CacheConfig implements ConfigurationObserver and registers
itself for
+ * notifications of dynamic configuration changes. The default is a noop.
+ * @param config the new configuration to be updated.
+ */
+ default void refreshConfiguration(Configuration config) {
Review Comment:
Ok, have pushed a new commit with these suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
