rmdmattingly commented on code in PR #6294:
URL: https://github.com/apache/hbase/pull/6294#discussion_r1844175831
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/mapreduce/MapReduceBackupMergeJob.java:
##########
@@ -228,13 +228,15 @@ protected void copyMetaData(FileSystem fs, Path
tmpBackupDir, Path backupDirPath
if (
fileName.indexOf(FSTableDescriptors.TABLEINFO_DIR) > 0
|| fileName.indexOf(HRegionFileSystem.REGION_INFO_FILE) > 0
+ || fileName.indexOf(BackupManifest.MANIFEST_FILE_NAME) > 0
Review Comment:
This becomes necessary because the manifest file would implicitly move to
the tmp directory during the merge process, since it follows the application's
working root dir rather than its original root dir. So, before this changeset,
rewriting the manifest would always update the original root dir (where we want
this eventually), but with this changeset rewriting the manifest would put it
in the tmp dir. Since the tmp dir will be purged, we need to make sure we copy
the manifest file out first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
