rmdmattingly commented on code in PR #6294:
URL: https://github.com/apache/hbase/pull/6294#discussion_r1803051595
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/HBackupFileSystem.java:
##########
@@ -97,10 +100,18 @@ public static Path getTableBackupPath(TableName tableName,
Path backupRootPath,
private static Path getManifestPath(Configuration conf, Path backupRootPath,
String backupId)
throws IOException {
+ return getManifestPath(conf, backupRootPath, backupId, true);
+ }
+
+ /* Visible for testing only */
+ @RestrictedApi(explanation = "Should only be called internally or in tests",
link = "",
Review Comment:
Just to be particularly specific about why this is visible to the whole
package. Happy to rip this out if you don't think it's important
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
