ndimiduk commented on code in PR #6294: URL: https://github.com/apache/hbase/pull/6294#discussion_r1847965015
########## hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/mapreduce/MapReduceBackupMergeJob.java: ########## @@ -228,13 +228,15 @@ protected void copyMetaData(FileSystem fs, Path tmpBackupDir, Path backupDirPath if ( fileName.indexOf(FSTableDescriptors.TABLEINFO_DIR) > 0 || fileName.indexOf(HRegionFileSystem.REGION_INFO_FILE) > 0 + || fileName.indexOf(BackupManifest.MANIFEST_FILE_NAME) > 0 Review Comment: Do we have a test that asserts that we haven't lost any critical components of a backup image during processing it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org