guluo2016 commented on code in PR #6385:
URL: https://github.com/apache/hbase/pull/6385#discussion_r1818855950
##########
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionFileSystem.java:
##########
@@ -184,6 +185,62 @@ public void testBlockStoragePolicy() throws Exception {
TEST_UTIL.shutdownMiniCluster();
}
}
+ @Test
+ public void testMobStoreStoragePolicy() throws Exception {
+ TEST_UTIL = new HBaseTestingUtil();
+ Configuration conf = TEST_UTIL.getConfiguration();
+ TEST_UTIL.startMiniCluster();
+ Table table = TEST_UTIL.createTable(TABLE_NAME, FAMILIES);
+ assertEquals("Should start with empty table", 0,
TEST_UTIL.countRows(table));
+ HRegionFileSystem regionFs = getHRegionFS(TEST_UTIL.getConnection(),
table, conf);
+ try (Admin admin = TEST_UTIL.getConnection().getAdmin()) {
+ ColumnFamilyDescriptorBuilder cfdA =
ColumnFamilyDescriptorBuilder.newBuilder(FAMILIES[0]);
+ cfdA.setValue(HStore.BLOCK_STORAGE_POLICY_KEY, "ONE_SSD");
Review Comment:
> We believe this is a bug, so I fix it like this pr
I agree with you.
> but I'm not sure how this is determined in our community.
In my personal opinion, the storage strategy for MOB should be consistent
with the column family.
Perhaps we can discuss it with Nihal and others together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
