xieyupei commented on code in PR #6385: URL: https://github.com/apache/hbase/pull/6385#discussion_r1820411627
########## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java: ########## @@ -264,11 +265,10 @@ protected HStore(final HRegion region, final ColumnFamilyDescriptor family, region.getRegionFileSystem().createStoreDir(family.getNameAsString()); // set block storage policy for store directory - String policyName = family.getStoragePolicy(); - if (null == policyName) { - policyName = this.conf.get(BLOCK_STORAGE_POLICY_KEY, DEFAULT_BLOCK_STORAGE_POLICY); - } - region.getRegionFileSystem().setStoragePolicy(family.getNameAsString(), policyName.trim()); + this.policyName = Optional.ofNullable(family.getStoragePolicy()) Review Comment: yes, no logic change. just to simplify assigning values to "this.policyName" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org